[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870460#comment-16870460
]
Jacques Le Roux commented on OFBIZ-10966:
-----------------------------------------
Hi Jayansh,
I did not really review, only glanced through the patch. It applies and sounds
good at 1st glance. I noticed we miss entries in webtools main page. I guess a
"Entity Json Tools" with related entries would fit. With "Import/Export" menu I
can see the 2 Json export and import sub-menus. I wonder if we should not have
the same options than for XML. Maybe not all, "export all", "import dir",
others?
I only tried to export all entities. I'm on Windows 7. I'm not sure why I got
refused access, even on my own directories (user\...) and in admin mode in root
(c:):(. Anyway I get the same with XML export. I was OK last time I tried,
certainly a local issue. Not a problem with your patch because using the "Out
to browser" option works.
So it needs more reviews but it sounds a good start to me.
> JSON entity data import and export utility
> ------------------------------------------
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Reporter: Jayansh Shinde
> Assignee: Jayansh Shinde
> Priority: Minor
> Attachments: OFBIZ-10966.patch
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> <Party partyId="123456" partyTypeId="PERSON" statusId="PARTY_ENABLED"/>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List<GenericValue>, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
