[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903765#comment-16903765
]
Jacopo Cappellato commented on OFBIZ-10145:
-------------------------------------------
Hi all,
I need some help testing my patch because when I generate the wrapper file
named 'gradlew' it contains the following setting:
{quote}DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{quote}
instead of:
{quote}DEFAULT_JVM_OPTS=""
{quote}
With the former, I am getting an out-of-memory error when I try to build OFBiz.
I need your help to test it (both the gradlew.bat and the gradlew file) in your
environment.
Steps to replicate:
1) get a fresh checkout of 16.11
2) remove the files: gradlew and gradlew.bat
3) re-create them with the command:
{quote}gradle wrapper --gradle-version 2.13
{quote}
4) run the command:
./gradlew build
You should get an error java.lang.OutOfMemoryError
The error can be fixed by editing gradlew to change this:
{quote} DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{quote}
into this
{quote}DEFAULT_JVM_OPTS=""
{quote}
Can you confirm this behavior?
I could fix it, without editing gradlew, by adding to the OFBiz home folder a
file named gradle.properties containing:
{quote}org.gradle.jvmargs="-Xmx512m"
{quote}
It would be great if you could also test this.
Thanks.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 17.12.01, 16.11.06, 18.12.01
> Reporter: Jacques Le Roux
> Assignee: Nicolas Malin
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
