[
https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945598#comment-16945598
]
Devanshu Vyas edited comment on OFBIZ-11236 at 10/7/19 5:51 AM:
----------------------------------------------------------------
Hi [~gpierre],
In the initial review of the patch, I noticed that there are a couple of
changes which seems to be from the older version of the files.
{code:java}
- <field name="lastModifiedDate" type="date-time"/>
- <field name="lastModifiedByUserLogin" type="id-vlong"/>
+ <field name="createdByUserLogin" type="id-vlong"></field>
+ <field name="lastModifiedByUserLogin" type="id-vlong"></field>
{code}
{code:java}
@@ -311,10 +309,9 @@
<key-map field-name="lastModifiedByUserLogin"
rel-field-name="userLoginId"/>
</relation>
</entity>
- <entity entity-name="OldPicklistStatusHistory"
table-name="PICKLIST_STATUS_HISTORY"
+ <entity entity-name="PicklistStatusHistory"
{code}
And please add the missing </service> tag in the updateShipmentNote service
definition as it is causing errors.
{code:java}
+ <service name="updateShipmentNote" engine="entity-auto"
default-entity-name="ShipmentNote" invoke="update" auth="true">
+ <description>Update shipment and note association</description>
+ <auto-attributes include="pk" mode="IN" optional="false"/>
+ <auto-attributes include="nonpk" mode="IN" optional="true"/>
<!-- Permission Services -->
<service name="checkCanChangeShipmentStatusPacked" engine="simple"
{code}
was (Author: devanshu.vyas):
Hi [~gpierre],
In the initial review of the patch, I noticed that there are a couple of
changes which seems to be from the older version of the files.
{code:java}
- <field name="lastModifiedDate" type="date-time"/>
- <field name="lastModifiedByUserLogin" type="id-vlong"/>
+ <field name="createdByUserLogin" type="id-vlong"></field>
+ <field name="lastModifiedByUserLogin" type="id-vlong"></field>
{code}
{code:java}
@@ -311,10 +309,9 @@
<key-map field-name="lastModifiedByUserLogin"
rel-field-name="userLoginId"/>
</relation>
</entity>
- <entity entity-name="OldPicklistStatusHistory"
table-name="PICKLIST_STATUS_HISTORY"
+ <entity entity-name="PicklistStatusHistory"
{code}
> Add shipment notes
> ------------------
>
> Key: OFBIZ-11236
> URL: https://issues.apache.org/jira/browse/OFBIZ-11236
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: Trunk
> Reporter: Gaudin Pierre
> Priority: Minor
> Attachments: OFBIZ-11236_shipmentNotes.patch
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes
> associated with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it
> is possible to add a note. From the shipment overview a section displays the
> notes associated with the shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way,
> all the services allowing the management of notes have been associated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
