[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11304:
------------------------------------
Description:
The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the
check gradle task. It's "hard" to exactly know from where lint errors come
among all still present.
I think we should rely on a Checkstyle pre-commit hook like
https://gist.github.com/davetron5000/37350 to complement
tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a
lint error is present in the commit.
Every committer would have it installed locally and the problem would be gone
with some committers good will. I started a discussion about it at
https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition
years ago: https://markmail.org/message/gkgmko4axj3vtnv3
was:
The ofbizTrunkFrameworkPlugins build fail when a lint error is detected by the
Check gradle task. It's "hard" to exactly know from where they come.
I think we should rely on a Checkstyle pre-commit hook:
https://gist.github.com/davetron5000/37350 to complement
tasks.checkstyleMain.maxErrors
Every committer would have it installed locally and the problem would be gone
\o/
> Install a Checkstyle pre-commit on every committer machine
> ----------------------------------------------------------
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by
> the check gradle task. It's "hard" to exactly know from where lint errors
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
> https://gist.github.com/davetron5000/37350 to complement
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when
> a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone
> with some committers good will. I started a discussion about it at
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
