[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990783#comment-16990783 ]
Jacques Le Roux edited comment on OFBIZ-11304 at 12/8/19 9:09 AM: ------------------------------------------------------------------ Hi Mathieu, Though I use it sometimes, I'm not a big fan of commits bursts. So I did not think about that. I agree it would be better in pre push indeed. was (Author: jacques.le.roux): Hi Mathieu, Though I use it sometimes, I'm not a big fan of commits burst. So I did not think about that. I agree it would be better in pre push indeed. > Install a Checkstyle pre-commit on every committer machine > ---------------------------------------------------------- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task > Affects Versions: Trunk > Reporter: Jacques Le Roux > Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)