[ 
https://issues.apache.org/jira/browse/OFBIZ-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995516#comment-16995516
 ] 

Jacques Le Roux commented on OFBIZ-11279:
-----------------------------------------

After reading the link in the description I checked on my machine if we had 
CR/LF EOLs. We have indeed some:
 
{noformat}
Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk)
$ git grep -I --files-with-matches --perl-regexp '\r' HEAD
HEAD:framework/base/src/main/resources/org/apache/ofbiz/base/OfbizDslDescriptorForEclipse.dsld
HEAD:framework/entityext/src/doc/asciidoc/EntitySync-manual.adoc
HEAD:framework/service/src/main/java/org/apache/ofbiz/service/job/JobPriority.java
HEAD:runtime/.gitignore
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/core.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-af-ZA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-AE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-BH.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-DZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-EG.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-IQ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-JO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-KW.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-LB.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-LY.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-MA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-OM.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-QA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-SA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-SY.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-TN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ar-YE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-az-Cyrl-AZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-az-Latn-AZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-be-BY.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-bg-BG.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-bs-Latn-BA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ca-ES.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-cs-CZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-cy-GB.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-da-DA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-da-DK.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-de-AT.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-de-CH.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-de-DE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-de-LI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-de-LU.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-dv-MV.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-el-GR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-029.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-AU.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-BZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-CA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-GB.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-IE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-JM.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-NZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-PH.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-TT.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-US.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-ZA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-en-ZW.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-AR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-BO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-CL.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-CO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-CR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-DO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-EC.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-ES.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-GT.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-HN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-MX.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-NI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-PA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-PE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-PR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-PY.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-SV.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-UY.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-es-VE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-et-EE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-eu-ES.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fa-IR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fi-FI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fo-FO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fr-BE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fr-CA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fr-CH.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fr-FR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fr-LU.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-fr-MC.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-gl-ES.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-gu-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-he-IL.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-hi-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-hr-BA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-hr-HR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-hu-HU.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-hy-AM.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-id-ID.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-is-IS.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-it-CH.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-it-IT.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ja-JP.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ka-GE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-kk-KZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-kn-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ko-KR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-kok-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ky-KG.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-lt-LT.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-lv-LV.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-mi-NZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-mk-MK.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-mn-MN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-mr-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ms-BN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ms-MY.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-mt-MT.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-nb-NO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-nl-BE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-nl-NL.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-nn-NO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ns-ZA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-pa-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-pl-PL.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-pt-BR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-pt-PT.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-quz-BO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-quz-EC.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-quz-PE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ro-RO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ru-RU.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sa-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-se-FI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-se-NO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-se-SE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sk-SK.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sl-SI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sma-NO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sma-SE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-smj-NO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-smj-SE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-smn-FI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sms-FI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sq-AL.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sr-Cyrl-BA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sr-Cyrl-CS.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sr-Latn-BA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sr-Latn-CS.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sv-FI.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sv-SE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-sw-KE.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-syr-SY.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ta-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-te-IN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-th-TH.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-tn-ZA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-tr-TR.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-tt-RU.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-uk-UA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-ur-PK.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-uz-Cyrl-UZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-uz-Latn-UZ.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-vi-VN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-xh-ZA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-zh-CN.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-zh-HK.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-zh-MO.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-zh-SG.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-zh-TW.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date-zu-ZA.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/date.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/extras.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/parser.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/sugarpak.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/datejs/time.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/fjTimer/jquerytimer-min.js
HEAD:themes/common-theme/webapp/common/js/jquery/plugins/fjTimer/jquerytimer.js
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/africa
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/antarctica
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/asia
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/australasia
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/backward
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/etcetera
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/europe
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/factory
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/iso3166.tab
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/leapseconds
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/africa
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/antarctica
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/asia
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/australasia
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/backward
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/etcetera
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/europe
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/factory
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/iso3166.tab
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/leapseconds
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/northamerica
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/pacificnew
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/solar87
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/solar88
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/solar89
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/southamerica
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/systemv
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/min/zone.tab
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/northamerica
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/pacificnew
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/solar87
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/solar88
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/solar89
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/southamerica
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/systemv
HEAD:themes/common-theme/webapp/common/js/plugins/date/timezones/zone.tab
(END)
Waiting for data... (interrupt to abort)
Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk)
{noformat}
Then I wondered if "git text=auto" in .gitattributes would not be enough. But 
reading 
[https://stackoverflow.com/questions/21472971/what-is-the-purpose-of-text-auto-in-gitattributes-file]
 and as we have already defined EOLs in Svn I decided to use the same 
definitions in .gitattributes, ie:

 
{noformat}
# Set the default behavior, in case people don't have core.autocrlf set.
*            text=auto

# Explicitly declare text files to always be normalized and converted
# to native line endings on checkout.
*.java       text
*.groovy     text
*.jsp        text
*.ftl        text
*.js         text
*.sql        text
*.txt        text
*.properties text
*.xml        text
*.xsl        text
*.xsd        text
*.html       text
*.htm        text
*.css        text
*.gradle     text
*.md         text
Makefile     text
README       text
NOTICE       text
LICENSE      text
rc.ofbiz.*   text
*.less       text
*.adoc       text
*.sh         text

# Declare files that will always have CRLF line endings on checkout.
*.bat        text eol=crlf

# Denote all files that are truly binary and should not be modified.
*.png        binary
*.jpg        binary
*.gif        binary
*.tif        binary
*.zip        binary
*.jks        binary
*.ttf        binary
{noformat}

So if nobody is against I 'll commit this .gitattributes file and all changes 
from my machine in a week.

> Equivalent of svn:auto-props properties on the server:
> ------------------------------------------------------
>
>                 Key: OFBIZ-11279
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11279
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>
> We should have an equivalent of svn:auto-props properties on the server: 
> https://help.github.com/articles/dealing-with-line-endings/#per-repository-settings



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to