[
https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006344#comment-17006344
]
James Yong commented on OFBIZ-11313:
------------------------------------
Tested the patches. No functional change here.
I am ok with error handling being closer to the source, to simplify the code.
Also fine with the removal of MultivaluedMapContext.
> Parsing included controller files eagerly
> -----------------------------------------
>
> Key: OFBIZ-11313
> URL: https://issues.apache.org/jira/browse/OFBIZ-11313
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Mathieu Lirzin
> Priority: Minor
> Attachments:
> 0001-Improved-Retrieve-the-included-controller-files-eage.patch,
> 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
>
>
> Controller configuration files have the ability to include other controllers
> which can be useful to make the controller more modular and potentially
> reusable.
> Currently included controller files are retrieved lazily when reading the
> properties from a controller configuration. This technique avoids unnecessary
> work at startup but in this concrete case the gain in negligeable and has the
> drawback of requiring error handling everytime a property is read which is
> cumbersome.
> As a consequence it would be better to parse included files eagerly at
> startup time to be able to detect inclusion errors early and relaxing the
> error handling when reading properties since all the sensible work will be
> done when instantiating the {{ControllerConfig}} object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
