ASF subversion and git services commented on OFBIZ-11313:

Commit 7508917a0af0311694c37cf1ddd4231a0c8b3529 in ofbiz-framework's branch 
refs/heads/trunk from Mathieu Lirzin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7508917 ]

Improved: Remove ‘RequestHandler#ControllerConfig’ wrapper

‘RequestHandler#ControllerConfig’ was a wrapper around
‘ConfigXMLReader#ControllerConfig’ used as a convenience to gather
error handling when accessing configuration properties. Since the
later is now only throwing exceptions when instantiating the object,
‘RequestHandler#ControllerConfig’ is not useful anymore.

> Parsing included controller files eagerly
> -----------------------------------------
>                 Key: OFBIZ-11313
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11313
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: 
> 0001-Improved-Retrieve-the-included-controller-files-eage.patch, 
> 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
> Controller configuration files have the ability to include other controllers 
> which can be useful to make the controller more modular and potentially 
> reusable.
> Currently included controller files are retrieved lazily when reading the 
> properties from a controller configuration. This technique avoids unnecessary 
> work at startup but in this concrete case the gain in negligeable and has the 
> drawback of requiring error handling everytime a property is read which is 
> cumbersome.
> As a consequence it would be better to parse included files eagerly at 
> startup time to be able to detect inclusion errors early and relaxing the 
> error handling when reading properties since all the sensible work will be 
> done when instantiating the {{ControllerConfig}} object.

This message was sent by Atlassian Jira

Reply via email to