[ 
https://issues.apache.org/jira/browse/OFBIZ-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007573#comment-17007573
 ] 

Mathieu Lirzin edited comment on OFBIZ-11296 at 1/3/20 3:38 PM:
----------------------------------------------------------------

Hello I have included 
[^OFBIZ-11296_ignore-depends-on-when-a-component-load.xml-is-prese.patch] which 
fixes the regression where people were not able to add a custom 
{{component-load.xml}} files in a directory without getting "depends-on" 
attributes ignored. I will commit that fix in 3 days if nobody objects.

Regarding  
[^OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch]  
which replaces usages of {{component-load.xml}} files in framework/applications 
directories with {{depends-on}} declarations and have been reverted because of 
the "regression" described above, if [~mbrohl] (or others) does not provides a 
convincing explanation (which has been asked multiple times) why they consider 
the ability to mess with framework/applications {{component-load.xml}} a 
feature and not an implementation detail, I will recommit it in 3 days too.


was (Author: mthl):
Hello I have included 
[^OFBIZ-11296_ignore-depends-on-when-a-component-load.xml-is-prese.patch] which 
fixes the regression where people we not able to add a custom 
{{component-load.xml}} files in a directory without getting "depends-on" 
attributes ignored. I will commit that fix in 3 days if nobody objects.

Regarding  
[^OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch]  
which replaces usages of {{component-load.xml}} files in framework/applications 
directories with {{depends-on}} declarations and have been reverted because of 
the "regression" described above, if [~mbrohl] (or others) does not provides a 
convincing explanation (which has been asked multiple times) why they consider 
to ability to mess with framework/applications {{component-load.xml}} a feature 
and not an implementation detail, I will recommit it in 3 days too.

> Use 'depends-on' everywhere
> ---------------------------
>
>                 Key: OFBIZ-11296
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11296
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: 
> OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch, 
> OFBIZ-11296_ignore-depends-on-when-a-component-load.xml-is-prese.patch
>
>
> We currently have two ways to define component loading order. Either
> by using ‘depends-on’ attribute in “component-config.xml” or by adding
> a “component-load.xml” file at the root of a component directory.
> “depends-on” is more flexible because it handles partial ordering when
> “component-load.xml” defines a total order which is not necessarily
> meaningful, so it is better to rely only “depends-on”.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to