[
https://issues.apache.org/jira/browse/OFBIZ-11329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029060#comment-17029060
]
Jacques Le Roux commented on OFBIZ-11329:
-----------------------------------------
Hi James,
bq. Original code was: {{throw new
RequestHandlerExceptionAllowExternalRequests();}}
I know, I mean why using that instead of {{throw new
RequestHandlerException();}}? As its names shows
RequestHandlerExceptionAllowExternalRequests is specific to handling external
requests which are not allowed by default and can be allowed using
throwRequestHandlerExceptionOnMissingLocalRequest property: OFBIZ-5037. It's
minor and a moot point. But I see no reasons to use
RequestHandlerExceptionAllowExternalRequests there. IMO, it would be more clear
code with a simple RequestHandlerException. Do I miss something?
> setUserTimeZone should ran only once based on error
> ---------------------------------------------------
>
> Key: OFBIZ-11329
> URL: https://issues.apache.org/jira/browse/OFBIZ-11329
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework, webpos
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: James Yong
> Priority: Minor
> Attachments: OFBIZ-11329-plugins.patch, OFBIZ-11329.patch,
> OFBIZ-11329.patch
>
>
> This will be useful when committing CSRF solution as explained in OFBIZ-11306
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
