Daniel Watford created OFBIZ-11428:
--------------------------------------
Summary: Checkstyle incorrectly reports violation for missing new
line at end of file on Windows
Key: OFBIZ-11428
URL: https://issues.apache.org/jira/browse/OFBIZ-11428
Project: OFBiz
Issue Type: Improvement
Components: tools
Affects Versions: Trunk
Reporter: Daniel Watford
Assignee: Daniel Watford
If building on Windows with Ofbiz sources checked out from git using LF line
endings rather than CRLF line endings checkstyle will report violations stating
that source files do not end with a new line.
Issue is that when running on windows checkstyle assumes line endings to be
made up for CRLF and looks for those two characters at the end of a file. If
sources are checked out with LF line endings then only the LF character will be
present at the end of the file, causing checkstyle to report the violation.
This can be resolved by specifying checkstyle use LF for line endings, meaning
a newline at the end of a file will be detected correctly regardless of whether
sources are checked out in CRLF or LF line ending mode.
Flagged as backport needed as fix will help track compliance of release sources
without affecting Ofbiz functionality.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
