[ 
https://issues.apache.org/jira/browse/OFBIZ-10947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061571#comment-17061571
 ] 

Pierre Smits commented on OFBIZ-10947:
--------------------------------------

Patch available via https://github.com/apache/ofbiz-plugins/pull/11 See 
OFBIZ-11414

> Have DateDimension have a dimensionId that is based on the natural key
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-10947
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10947
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: bi
>    Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>              Labels: DateDimension, birt, dimension, dwh
>
> Currently the record sequencer (delegator.getNextSeqId) is used to determine 
> the dimensionId for the DateDimension. This is unnecessary as the date (when 
> correctly formatted) can be used. 
> When formatted as 'yyyyMMdd' a dimensionId could be 20190423, which is a 
> correctly 'sequenced' primary key. 
> It also makes it easier to set the foreign-key in fact tables by generating 
> it based on the date, than by retrieving the dimensionId based on a retrieval 
> through the getDimensionIdFromNaturalKey service.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to