ASF subversion and git services commented on OFBIZ-9164:

Commit 5988e27a0d80a891f01e34a9a835ceb6a4d3119a in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5988e27 ]

Improved: Implement the pretty print for keyword search


With OFBIZ-9164 and r1835891 I introduced
keywordConstraint::prettyPrintConstraint without implementation.
So the information is missing at top of page.

This implements it. It also amends 2 French labels

> Refactor ContentWorkerInterface methods signatures
> --------------------------------------------------
>                 Key: OFBIZ-9164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9164
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: content, framework, lucene, order, party, product, 
> workeffort
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: 17.12.01
>         Attachments: OFBIZ-9164 DataResourceWorker.java.patch, 
> OFBIZ-9164.patch
> While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an 
> issue due to r1652852 where Adrian improved the cacheKey in 
> FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). 
> Actually I'm not even sure it was done at r1652852 because Adrian did not 
> maintain the FormFactory svn history.
> Anyway, to make a long story short I had to introduce a DispatchContext 
> parameter when calling FormFactory.readFormDocument() when the code from 
> R13.07 only passed a null.
> This had an impact in the hierarchy tree because 
> FormFactory.readFormDocument() was called in DataResourceWorker class, where 
> the new code was called from renderDataResourceAsText(). So I instead of only 
> passing a Delegator I decided to pass only a LocalDispatcher parameter in 
> renderDataResourceAsText(), since we can get the Delegator  from the 
> LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText 
> hierarchy tree ending in DataResourceWorkerInterface and all related.
>  I finally decided to apply the same ["Change Method Signature" refactoring 
> pattern|http://refactoring.com/catalog/addParameter.html] to all cases 
> related to ContentWorkerInterface. No need to pass a delegator when you have 
> LocalDispatcher!
> Here I attach a patch for review, I'll commit in few days

This message was sent by Atlassian Jira

Reply via email to