[
https://issues.apache.org/jira/browse/OFBIZ-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073549#comment-17073549
]
James Yong commented on OFBIZ-11431:
------------------------------------
Hi [~pierresmits],
{quote}Re aspect 1
Indeed, if the field is crucial in the adopter implementation, then your
suggest solution can be applied by them in their update/migration scenarios.
{quote}
The proposed datamodel/entitydef/deprecated-entitymodel.xml file was meant to
be commented out by new adopters who don't want to use deprecated fields.
{quote}Re aspect 2
Doing a find on the code base on trunk branched of the combined set of repos
revealed multiple 'quantityUomId' field definitions in use, even more when
including derivatives like weightUomId, lenghtUomId, etc.
{quote}
Beside *quantityUomId*, you implied there can be other uom like *weightUomId*,
*lengthUomId* for *InvoiceItem* entity. Wouldn't it better to keep the existing
*uomId* field as it can be used for quantity, weight or length depending on
item?
> InvoiceItem: uomID is wrongly defined
> -------------------------------------
>
> Key: OFBIZ-11431
> URL: https://issues.apache.org/jira/browse/OFBIZ-11431
> Project: OFBiz
> Issue Type: Bug
> Components: datamodel
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Priority: Critical
> Labels: refactoring
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the InvoiceItem entity has the field uomId, per:
> {code:java}
> <field name="uomId" type="id"></field>
> {code}
> per the demo data this field is used to capture the currency of the invoice
> item. This is, however, wrong. The currency for invoice items is set in the
> invoice entity record (with field currencyUomId.
> The uomId in the invoice item is related to the quantity set, and must be
> correctly named: 'quantityUomId.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
