dixitdeepak commented on a change in pull request #76:
URL: https://github.com/apache/ofbiz-framework/pull/76#discussion_r415071220
##########
File path:
framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
##########
@@ -1625,8 +1625,8 @@ public EntityListIterator
findListIteratorByCondition(DynamicViewEntity dynamicV
* @see
org.apache.ofbiz.entity.Delegator#findCountByCondition(java.lang.String,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.util.EntityFindOptions)
*/
@Override
- public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition,
- EntityCondition havingEntityCondition, EntityFindOptions
findOptions) throws GenericEntityException {
+ public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition, Set<String> fieldsToSelect
Review comment:
@verma-pawan I think we need to keep the existing method signature as
well, and can pass null as fieldsToSelect to maintain backward compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
