[
https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092991#comment-17092991
]
Suraj Khurana commented on OFBIZ-10538:
---------------------------------------
Hello team,
Patch looks good to me, except one thing that we can pass false to set-if-null
attribute, would it make any difference to set it as null? Can't get any use
case for this.
Rest is good to go.
> Promised Datetime & Current Promised Date values not getting updated in
> OISGIR Entity
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10538
> URL: https://issues.apache.org/jira/browse/OFBIZ-10538
> Project: OFBiz
> Issue Type: Bug
> Components: order, product
> Affects Versions: Trunk
> Reporter: Deepak Nigam
> Assignee: Pawan Verma
> Priority: Major
> Attachments: OFBIZ-10538.patch
>
>
> While creating the sales order from the backend, if we set the 'Ship Before
> Date' it will be stored in OrderItemShipGroup.shipByDate field and same will
> be propagated to OrderItemShipGrpInvRes.promisedDateTime and
> OrderItemShipGrpInvRes.currentPromisedDate fields.
>
> On updating the 'Ship Before Date' from the order view page later, the
> promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup
> entity but remains the same in OrderItemShipGroupInvRes entity.
>
> As OrderItemShipGrpInvRes.promisedDateTime &
> OrderItemShipGrpInvRes.currentPromisedDate are being used in many services
> like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity',
> 'reserveProductInventory' etc., we should also update these on updating the
> 'Ship Before Date' from the order overview page.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
