[
https://issues.apache.org/jira/browse/OFBIZ-11481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114680#comment-17114680
]
Priya Sharma commented on OFBIZ-11481:
--------------------------------------
Hello all,
I have created a PR for this task.
I have tried to keep the basic functionality and the logic as is, except the
following -
* simplified the logic to set the amount applied, if not set and either one of
billingAccountId or taxAuthGeoId is available (line 200)
{code:java}
<if-not-empty field="parameters.billingAccountId">
<if-empty field="paymentAppl.amountApplied">
<set field="paymentAppl.amountApplied" from-field="notAppliedPayment"/>
</if-empty>
</if-not-empty>
<if-not-empty field="parameters.taxAuthGeoId">
<if-empty field="paymentAppl.amountApplied">
<set field="paymentAppl.amountApplied" from-field="notAppliedPayment"/>
</if-empty>
</if-not-empty>{code}
* also eliminated the re-fetching of payment to set the paymentTypeId on the
result, as we have already fetch it. (line 209)
{code:java}
<entity-one entity-name="Payment" value-field="payment"/>
<field-to-result field="payment.paymentTypeId" result-name="paymentTypeId"/>
{code}
Please review and provide your feedback.
> Convert createPaymentApplication service from mini-lang to groovy DSL
> ---------------------------------------------------------------------
>
> Key: OFBIZ-11481
> URL: https://issues.apache.org/jira/browse/OFBIZ-11481
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: Trunk
> Reporter: Devanshu Vyas
> Assignee: Priya Sharma
> Priority: Minor
>
> Convert the createPaymentApplication service code from mini-lang to groovy
> DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
