[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139169#comment-17139169
]
Jacques Le Roux edited comment on OFBIZ-11304 at 6/18/20, 12:24 PM:
--------------------------------------------------------------------
Awesome. Thank you Jacques!
>> I have still to see how to prevent a PR merge in case of failure
We can make it part of [Committers Roles and
Responsibilities|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities]
>> Maybe we can create our own CI server and use BuildBot has our status
>> server. But how to relate the failure of the checkstyle step there to GH
>> status is still to investigate...
+1. Let me explore more on it
>> Begin to be a lot for rejecting check style failures on PR merge, I better
>> understand Infra reaction now ;)
:)
was (Author: aditya.sharma):
Awesome. Thank you Jacques!
>> I have still to see how to prevent a PR merge in case of failure
We can make it part of [Committers Roles and Responsibilities
|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities]
>> Maybe we can create our own CI server and use BuildBot has our status
>> server. But how to relate the failure of the checkstyle step there to GH
>> status is still to investigate...
+1. Let me explore more on it
>> Begin to be a lot for rejecting check style failures on PR merge, I better
>> understand Infra reaction now ;)
:)
> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by
> the check gradle task. It's "hard" to exactly know from where lint errors
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
> https://gist.github.com/davetron5000/37350 to complement
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when
> a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone
> with some committers good will. I started a discussion about it at
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
