[
https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158025#comment-17158025
]
Aditya Sharma edited comment on OFBIZ-11251 at 7/15/20, 9:44 AM:
-----------------------------------------------------------------
Hi Jacques,
I tried backporting but got blocked as R17, we have Gradle 3.2 and as per the
official
[documentation|https://docs.gradle.org/3.2.1/dsl/org.gradle.api.plugins.quality.Checkstyle.html]
we do not have support for maxErrors. Along with that I got errors for
configuration as well, it seems the some of the modules added in config.xml
didn't existed for 3.2.
was (Author: aditya.sharma):
Hi Jacques,
I tried backporting but got blocked as R17, we have Gradle 3
> Use ‘checkstyle’ linting tool
> -----------------------------
>
> Key: OFBIZ-11251
> URL: https://issues.apache.org/jira/browse/OFBIZ-11251
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Aditya Sharma
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch
>
>
> Linting [1] is a software engineering practice which make the code
> more readable and maintainable by improving its consistency and
> avoiding potential programming mistakes.
> Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which
> provides such facility. The lint actions are triggered when running
> ‘gradle check’.
> There are a lot reported errors that will need to be fixed
> incrementally in the future. We ensure that new errors will not be
> introduced by defining a global threshold of “allowed” errors
> corresponding to the sum of errors currently found in the framework
> and in the official plugins.
> [1] https://en.wikipedia.org/wiki/Lint_(software)
> [2] https://checkstyle.org/
> [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
