[jira] [Commented] (OFBIZ-11943) Makes Cancel/Done buttons used in payment methods screens from SFA profile work as in "Create EFT Account" screen

[Jacques Le Roux (Jira)]

    [ 
https://issues.apache.org/jira/browse/OFBIZ-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172241#comment-17172241
 ] 

Jacques Le Roux commented on OFBIZ-11943:
-----------------------------------------

Thanks Priya,

I just added the same in party controller for deleteBillingAccount. I'll commit 
our changes soon.

While looking at the UI i found that even in stable, ie 
https://demo-stable.ofbiz.apache.org/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company
 there are too much expire buttons. 

If you look at the HTLM generated source you see:

{code:html}
<!-- Begin Template 
component://party/template/party/profileblocks/PaymentMethods.ftl -->

  <div id="partyPaymentMethod" class="screenlet">
    <div class="screenlet-title-bar">
      <ul>
        <li class="h3">Payment Method</li>
          <li><a 
href="https://demo-trunk.ofbiz.apache.org:443/sfa/control/editeftaccount?partyId=Company";>Create
 EFT Account</a></li>
          <li><a 
href="https://demo-trunk.ofbiz.apache.org:443/sfa/control/editgiftcard?partyId=Company";>Create
 Gift Card</a></li>
          <li><a 
href="https://demo-trunk.ofbiz.apache.org:443/sfa/control/editcreditcard?partyId=Company";>Create
 Credit Card</a></li>
          <li><a 
href="https://demo-trunk.ofbiz.apache.org:443/sfa/control/EditBillingAccount?partyId=Company";>Create
 Billing Account</a></li>
          <li><a 
href="https://demo-trunk.ofbiz.apache.org:443/sfa/control/AddCheckAccount?partyId=Company";>Add
 Check Account</a></li>
      </ul>
      <br class="clear" />
    </div>
    <div class="screenlet-body">
        <table class="basic-table" cellspacing="0">
            <tr>
                <form name="deletePaymentMethod_SC_CHECKING" method="post" 
action="https://demo-trunk.ofbiz.apache.org:443/sfa/control/deletePaymentMethod";>
                  <input type="hidden" name="partyId" value="Company" />
                  <input type="hidden" name="paymentMethodId" 
value="SC_CHECKING" />
                  <input type="submit" value="Expire"/>
                </form>
              </td> 
            </tr>
            <tr>
                <form name="deletePaymentMethod_ABN_CHECKING" method="post" 
action="https://demo-trunk.ofbiz.apache.org:443/sfa/control/deletePaymentMethod";>
                  <input type="hidden" name="partyId" value="Company" />
                  <input type="hidden" name="paymentMethodId" 
value="ABN_CHECKING" />
                  <input type="submit" value="Expire"/>
                </form>
              </td> 
            </tr>
            <tr>
{code}
I use HTML validator extensions in FF, and it shows the 2 expire forms in red. 
I don't know what it means, but certainly noithing good.

There are also these blocks below
{code:html}
       <td class="button-col">
                    <a 
href="https://demo-trunk.ofbiz.apache.org:443/sfa/control/editcreditcard?partyId=Company&amp;paymentMethodId=AMEX_01";>Update</a>
                <form name="deletePaymentMethod_AMEX_01" method="post" 
action="https://demo-trunk.ofbiz.apache.org:443/sfa/control/deletePaymentMethod";>
                  <input type="hidden" name="partyId" value="Company" />
                  <input type="hidden" name="paymentMethodId" value="AMEX_01" />
                  <input type="submit" value="Expire"/>
                </form>
              </td> 
            </tr>
            <tr>
                <td class="button-col">
                  &nbsp;
                <form name="deletePaymentMethod_PETTY_CASH" method="post" 
action="https://demo-trunk.ofbiz.apache.org:443/sfa/control/deletePaymentMethod";>
                  <input type="hidden" name="partyId" value="Company" />
                  <input type="hidden" name="paymentMethodId" 
value="PETTY_CASH" />
                  <input type="submit" value="Expire"/>
                </form>
              </td> 
{code}

If you inspect these buttons, and actually the whole page, clearly it's all 
wrong. 
For instance the other expire buttons (for email at least) show the same wrong 
behaviour. 


> Makes Cancel/Done buttons used in payment methods screens from SFA profile 
> work as in "Create EFT Account" screen
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-11943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11943
>             Project: OFBiz
>          Issue Type: Bug
>          Components: sfa
>    Affects Versions: 17.12.04
>            Reporter: Jacques Le Roux
>            Assignee: Priya Sharma
>            Priority: Major
>
> Go to profile page 
> https://localhost:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company
> Get to create one of the payment method screen. Use the Cancel/Done button 
> there, you don't get back to the profile. One exception is "Create EFT 
> Account", you can even create an EFT account.
> But if you use any of 
> *  Create Gift Card
> *  Create Credit Card
> *  Create Billing Account
> *  Add Check Account
>  you can't get back.
> All of those use 
> https://localhost:8443/sfa/control/viewprofile?partyId=Company when "Create 
> EFT Account" uses https://localhost:8443/sfa/control/backHome



--
This message was sent by Atlassian Jira
(v8.3.4#803005)