[ 
https://issues.apache.org/jira/browse/OFBIZ-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182256#comment-17182256
 ] 

Jacques Le Roux commented on OFBIZ-11969:
-----------------------------------------

 Hi Alex,

 

This is what I get with the grep:

 
{noformat}
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Bootstrap v4.3.1 (https://getbootstrap.com/)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Copyright 2011-2019 The Bootstrap Authors 
(https://github.com/twbs/bootstrap/graphs/contributors)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: (global 
= global || self, factory(global.bootstrap = {}, global.jQuery, global.Popper));
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Bootstrap (v4.3.1): util.js
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: throw 
new TypeError('Bootstrap\'s dropdowns require Popper.js 
(https://popper.js.org/)');
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: // 
https://github.com/twbs/bootstrap/issues/24251
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Bootstrap (v4.3.1): tools/sanitizer.js
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: throw 
new TypeError('Bootstrap\'s tooltips require Popper.js 
(https://popper.js.org/)');
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Bootstrap (v4.3.1): index.js
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: * 
Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: throw 
new TypeError('Bootstrap\'s JavaScript requires jQuery. jQuery must be included 
before Bootstrap\'s JavaScript.');
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js: throw 
new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less 
than v4.0.0');
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.js://# 
sourceMappingURL=bootstrap.js.map
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.min.js: * 
Bootstrap v4.3.1 (https://getbootstrap.com/)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.min.js: * 
Copyright 2011-2019 The Bootstrap Authors 
(https://github.com/twbs/bootstrap/graphs/contributors)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.min.js: * 
Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
plugins/ecommerce/webapp/ecommerce/js/bootstrap/js/bootstrap-4.3.1.min.js://# 
sourceMappingURL=bootstrap-4.3.1.min.js.map
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_advanced.html: <!-- 
Bootstrap CSS -->
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_advanced.html: <p 
class="lead">A jQuery based plugin that shows bootstrap modal with cookie info. 
It is GDPR/RODO compatible. The plugin shows the message on the users first 
visit and then every 30 days (by default).</p>
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_advanced.html: <!-- 
jQuery first, then Popper.js, then Bootstrap JS -->
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_advanced.html: <script 
src="https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/js/bootstrap.min.js"; 
integrity="sha384-ChfqqxuZUCnJSK3+MXmPNIyE6ZbWh2IMqE241rYiqJxyMiZ6OW/JmZQ5stwEULTy"
 crossorigin="anonymous"></script>
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_simple.html: <!-- 
Bootstrap CSS -->
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_simple.html: <p 
class="lead">A jQuery based plugin that shows bootstrap modal with cookie info. 
It is GDPR/RODO compatible. The plugin shows the message on the users first 
visit and then every 30 days (by default).</p>
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_simple.html: <!-- 
jQuery first, then Popper.js, then Bootstrap JS -->
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/demo_simple.html: <script 
src="https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/js/bootstrap.min.js"; 
integrity="sha384-ChfqqxuZUCnJSK3+MXmPNIyE6ZbWh2IMqE241rYiqJxyMiZ6OW/JmZQ5stwEULTy"
 crossorigin="anonymous"></script>
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/jquery.bs.gdpr.cookies.js: 
* Name: Bootstrap GDPR Cookies
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/jquery.bs.gdpr.cookies.js: 
* Description: jQuery based plugin that shows bootstrap modal with cookie info
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/README.MD:A jQuery based 
plugin that shows bootstrap modal with cookie info. It is GDPR/RODO compatible. 
The plugin shows the message on the users first visit and then every 30 days 
(by default).
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/README.MD:Here is a demo 
page hosted by 
[jqueryscript.net](https://www.jqueryscript.net/demo/GDPR-Cookie-Consent-Bootstrap-4-bsgdprcookies/)
plugins/ecommerce/webapp/ecommerce/js/bsgdprcookies/README.MD:1. Include 
Bootstrap
plugins/ecommerce/widget/Theme.xml: <property name="VT_HDR_JAVASCRIPT['add']" 
value="/ecommerce/js/bootstrap/js/bootstrap-4.3.1.min.js"/>
plugins/multiflex/widget/Theme.xml: <property name="VT_HDR_JAVASCRIPT['add']" 
value="/ecommerce/js/bootstrap/js/bootstrap-4.3.1.min.js"/>
plugins/solr/webapp/solr/js/require.js: //end of the file to bootstrap
plugins/solr/webapp/solr/libs/angular.js: bootstrap: true,
plugins/solr/webapp/solr/libs/angular.js: * Use this directive to 
**auto-bootstrap** an AngularJS application. The `ngApp` directive
plugins/solr/webapp/solr/libs/angular.js: * found in the document will be used 
to define the root element to auto-bootstrap as an
plugins/solr/webapp/solr/libs/angular.js: * application. To run multiple 
applications in an HTML document you must manually bootstrap them using
plugins/solr/webapp/solr/libs/angular.js: * {@link angular.bootstrap} instead. 
AngularJS applications cannot be nested within each other.
plugins/solr/webapp/solr/libs/angular.js: * `ngApp` is the easiest, and most 
common way to bootstrap an application.
plugins/solr/webapp/solr/libs/angular.js:function angularInit(element, 
bootstrap) {
plugins/solr/webapp/solr/libs/angular.js: bootstrap(appElement, module ? 
[module] : [], config);
plugins/solr/webapp/solr/libs/angular.js: * @name angular.bootstrap
plugins/solr/webapp/solr/libs/angular.js: * See: {@link guide/bootstrap 
Bootstrap}
plugins/solr/webapp/solr/libs/angular.js: * Note that Protractor based 
end-to-end tests cannot use this function to bootstrap manually.
plugins/solr/webapp/solr/libs/angular.js: * angular.bootstrap(document, 
['demo']);
plugins/solr/webapp/solr/libs/angular.js:function bootstrap(element, modules, 
config) {
plugins/solr/webapp/solr/libs/angular.js: // We need to expose 
`angular.$$minErr` to modules such as `ngResource` that reference it during 
bootstrap
plugins/solr/webapp/solr/libs/angular.js: * {@link angular.bootstrap} to 
simplify this process for you.
plugins/solr/webapp/solr/libs/angular.js: 'bootstrap': bootstrap,
plugins/solr/webapp/solr/libs/angular.js: * an animation. Upon bootstrap the 
classNameFilter value is not set at all and will
plugins/solr/webapp/solr/libs/angular.js: * concurrently (common during 
application bootstrap).
plugins/solr/webapp/solr/libs/angular.js:// bootstrap the system (before $parse 
is instantiated), for this reason we just have
plugins/solr/webapp/solr/libs/angular.js: if (window.angular.bootstrap) {
plugins/solr/webapp/solr/libs/angular.js: //but we will rebind on bootstrap 
again.
plugins/solr/webapp/solr/libs/angular.js: angularInit(document, bootstrap);
plugins/solr/webapp/solr/libs/angular.min.js:"provider"),factory:a("$provide","factory"),service:a("$provide","service"),value:a("$provide","value"),constant:a("$provide","constant","unshift"),animation:a("$animateProvider","register"),filter:a("$filterProvider","register"),controller:a("$controllerProvider","register"),directive:a("$compileProvider","directive"),config:q,run:function(a){e.push(a);return
 this}};h&&q(h);return u})}})}function 
Pd(b){z(b,{bootstrap:sc,copy:Ea,extend:z,equals:fa,element:B,forEach:s,injector:Ob,noop:C,bind:nc,toJson:$a,
 
{noformat}
So we are not concerned with the rest. I'll replace accordingly

 

> bootstrap-bundle*.js contains bootstrap*.js
> -------------------------------------------
>
>                 Key: OFBIZ-11969
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11969
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Alex Bodnaru
>            Priority: Trivial
>         Attachments: p-bootstrap-bundle-css.patch, 
> p-bootstrap-bundle-only.patch
>
>
> non-bundle is redundant, with performance hit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to