JacquesLeRoux edited a comment on pull request #231:
URL: https://github.com/apache/ofbiz-framework/pull/231#issuecomment-678665728


   Hi Girish,
   
   Looks good to me, jsut that you should avoid to use tabs and left trailing 
spaces ;)
   
   C:\projectsASF\Git\ofbiz-framework>git apply 231.patch
   231.patch:22: space before tab in indent.
                           <xs:annotation>
   231.patch:25: space before tab in indent.
                                   </xs:element>
   231.patch:54: trailing whitespace.
   231.patch:55: trailing whitespace.
   231.patch:61: space before tab in indent.
                   children = new ArrayList<>();
   warning: squelched 4 whitespace errors
   warning: 9 lines add whitespace errors.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to