[
https://issues.apache.org/jira/browse/OFBIZ-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182736#comment-17182736
]
ASF subversion and git services commented on OFBIZ-10677:
---------------------------------------------------------
Commit a61fe713f2417c889e67a3f6c3c512171fc442bb in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a61fe71 ]
Fixed: svg files not removed on clean (OFBIZ-11976)
Files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg, in many plugins,
don't get removed on clean.
I simply missed to clean them in pluginAsciidoc Gradle task (OFBIZ-10677)
Thanks: Alex Bodnaru for report
> Standalone Asciidoc plugins documents can't render logo correctly in PDF
> ------------------------------------------------------------------------
>
> Key: OFBIZ-10677
> URL: https://issues.apache.org/jira/browse/OFBIZ-10677
> Project: OFBiz
> Issue Type: Bug
> Components: ALL PLUGINS
> Affects Versions: Release Branch 17.12, Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: 17.12.01
>
>
> Asciidoc plugins documents should be standalone as described in
> [Documentation
> guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc].
> When rendering in PDF we should use the
> {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a
> reason, maybe related to
> [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there
> is a conflict between declaring
> {code}
> :imagesdir: ./images
> {code}
> and
> {code}
> ifdef::backend-pdf[]
> :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache
> OFBiz Logo, pdfwidth=4.25in, align=center]
> :source-highlighter: rouge
> endif::[]
> {code}
> in the same file.
> You then get
> {code}
> [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo,
> pdfwidth=4.25in, align=center]
> {code}
> instead of the logo in the 1st page of the PDF document.
> So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure
> yet, so I create this Jira more as a reminder.
> For now I'll not put logos in plugins standalone files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
