[ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185321#comment-17185321
 ] 

Jacques Le Roux edited comment on OFBIZ-11926 at 8/26/20, 4:52 PM:
-------------------------------------------------------------------

Hi Suraj,

About JsLanguageFilesMapping, I wrote:
bq. I think you should look at JsLanguageFileMappingCreator.java. At 1st glance 
I see no reasons why you could not change the method names.
What I mean is you should make the changes in JsLanguageFileMappingCreator.java 
and then generate the related files, ie
* JsLanguageFilesMapping.java
* JsLanguageFilesMapping.ftl
by running the createJsLanguageFileMapping service

JsLanguageFilesMappingTransform.java is OK as is. It's a "static file", ie not 
changed by JsLanguageFileMappingCreator.java.


was (Author: jacques.le.roux):
Hi Suraj,

About JsLanguageFilesMapping, I wrote:
bq. I think you should look at JsLanguageFileMappingCreator.java. At 1st glance 
I see no reasons why you could not change the method names.
What I mean is you should make the changes in JsLanguageFileMappingCreator.java 
and then generate the related files, ie
* JsLanguageFilesMapping.java
* JsLanguageFilesMapping.ftl
by running createJsLanguageFileMapping

JsLanguageFilesMappingTransform.java is OK as is. It's a "static file", ie not 
changed by JsLanguageFileMappingCreator.java.

> Checkstyle: Variable name must match pattern
> --------------------------------------------
>
>                 Key: OFBIZ-11926
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11926
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11926-plugins.patch, OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming patternĀ 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to