[
https://issues.apache.org/jira/browse/OFBIZ-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187243#comment-17187243
]
Akash Jain edited comment on OFBIZ-9419 at 8/30/20, 4:45 PM:
-------------------------------------------------------------
If ProductStoreEmailSetting data setup properly and added bodyScreenLocation
correctly then there is no need of
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method which used
a Map to get screen location (hardcoded). Also, there are total 36 rows of
ProductStoreEmailSetting table and put only 14 hardcoded screen location into
Map.
I think we are good to remove
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method, attached
patch for the same.
If we want to go with
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method then should
to handle it properly, like,
– create SystemProperty data for all emailTypes to get screen location instead
of hardcoded them
– take care of it for all 36 emailTypes instead 14 emailTypes only
I will remove ProductStoreWorker.getDefaultProductStoreEmailScreenLocation
method as attached patch soon, thanks!
was (Author: akash.jain):
If ProductStoreEmailSetting data setup properly and added bodyScreenLocation
correctly then there is no need of
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method which used
a Map to get screen location (hardcoded). Also, there are total 36 rows of
ProductStoreEmailSetting table and put only 14 hardcoded screen location into
Map.
I think we are good to remove
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method, attached
patch for the same.
If we want to go with
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method then should
to handle it properly, like,
-- create SystemProperty data for all emailTypes to get screen location instead
of hardcoded them
-- take care of it for all 36 emailTypes instead 14 emailTypes only
Please put your valuable thoughts else I will remove
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method as attached
patch, thanks!
> Remove ProductStoreWorker dependencies on ecommerce email screen forms
> ----------------------------------------------------------------------
>
> Key: OFBIZ-9419
> URL: https://issues.apache.org/jira/browse/OFBIZ-9419
> Project: OFBiz
> Issue Type: Sub-task
> Reporter: Taher Alkhateeb
> Assignee: Akash Jain
> Priority: Minor
> Attachments: OFBIZ-9419.patch
>
>
> The
> [ProductStoreWorker|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java]
> has dependencies on ecommerce as shown in below code snippet. This whole
> logic must be removed properly.
> Also, we need to implement a minimal email screen just to be able to test
> email functionality with a minimal template.
> {code}
> private static Map<String, String> defaultProductStoreEmailScreenLocation
> = new HashMap<String, String>();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM",
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE",
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER",
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE",
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY",
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT",
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE",
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL",
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE",
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD",
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM",
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE",
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND",
> "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
> defaultProductStoreEmailScreenLocation.put("PRDS_CUST_REGISTER",
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
