danwatford commented on pull request #250: URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758538114
Hi @ieugen , It was my first commit so I was very keen to ensure I followed ofbiz conventions. However there are examples in the git log of merge commits being used rather than committers applying patches. The good thing about merge commits is that the original author is shown in the log and systems like GitHub profiles can better represent individual developers' activities. In this case I wanted to add an extra comment about why we needed to disable caching in URLConnections, but perhaps better would have been to ask you to commit the comment and squash your commits accordingly. I'm happy to revisit and alter my committer workflow in line with community guidelines. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
