dixitdeepak commented on a change in pull request #252:
URL: https://github.com/apache/ofbiz-framework/pull/252#discussion_r560112591
##########
File path: applications/order/groovyScripts/order/CompanyHeader.groovy
##########
@@ -135,12 +136,22 @@ if (!partyId) {
}
// the logo
-partyGroup = from("PartyGroup").where("partyId", partyId).queryOne()
+GenericValue partyGroup = from("PartyGroup").where("partyId",
partyId).queryOne()
if (partyGroup) {
- partyContentWrapper = new PartyContentWrapper(dispatcher, partyGroup,
locale, EntityUtilProperties.getPropertyValue("content", "defaultMimeType",
"text/html; charset=utf-8", delegator))
- partyContent =
partyContentWrapper.getFirstPartyContentByType(partyGroup.partyId , partyGroup,
"LGOIMGURL", delegator)
+ GenericValue partyContent =
PartyContentWrapper.getFirstPartyContentByType(partyId, partyGroup,
"LGOIMGURL", delegator)
Review comment:
I think here we can use getPartyContentAsText directly, it will give you
the url stored in dataResource, also it will take care to read data from other
supported types as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
