[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

[GitBox]

adityasharma7 commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591


   Hi @JacquesLeRoux,
   This is done now. Initially, I have added only jQuery, jQuery browser, and 
Validate plugin through npm. As these are the libraries required for the front 
end to work I have kept the npmInstall task part of the Java build, so it 
executes on each tasks.
   
   Steps to verify:
   1. Fetch the branch on your local
   2. Start the server
   You will notice packages being downloaded with npmInstall task
   
   <img width="893" alt="image" 
src="https://user-images.githubusercontent.com/15027245/118508711-0dfd4900-b74d-11eb-8888-18863cd40dcc.png";>
   
   You will find the node_modules under the js folder
   
   <img width="257" alt="image" 
src="https://user-images.githubusercontent.com/15027245/118508970-4866e600-b74d-11eb-820c-2db716fd3b11.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org