[GitHub] [ofbiz-framework] danwatford commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

[GitBox]

danwatford commented on pull request #220:
URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-848836469


   Hi @JacquesLeRoux - I just tested PR 220, visiting the test URL 
https://localhost:8443/partymgr/control/PartyGeoLocation?partyId=FrenchCustomer,
 and the map appears to render correctly.
   
   
![image](https://user-images.githubusercontent.com/5949502/119681226-c7d57300-be39-11eb-83d6-9019c347f737.png)
   
   I couldn't figure out how to configure OFBiz with my Google API key so ended 
up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl 
line 44 with my key. Line 44 looked similar to:
   `<script 
src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_"; 
type="application/javascript"></script>`
   
   Is there a way to configure ofbiz with the API key?
   
   Any other screens I can test in order to progress this PR?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org