[GitHub] [ofbiz-framework] JacquesLeRoux commented on a change in pull request #305: Clean: Remove SVN references in build (OFBIZ-12267)

[GitBox]

JacquesLeRoux commented on a change in pull request #305:
URL: https://github.com/apache/ofbiz-framework/pull/305#discussion_r662906421



##########
File path: themes/rainbowstone/README.md
##########
@@ -4,10 +4,10 @@
 # Rainbowstone theme
 This back-end OFBiz theme is bootstrap based and offers 4 colour variants. As 
an example
 
-<img 
src="http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/images/themeRuby.png";
 alt="Rainbowstone ruby colour variant" />
+<img 
src="https://raw.githubusercontent.com/apache/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/images/themeRuby.png";
 alt="Rainbowstone ruby colour variant" />
 
 ## License
-The Rainbowstone theme uses the Quicksand font which is licensed under the 
[SIL OPEN FONT LICENSE Version 
1.1](https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/fonts/quicksand/Quicksand
 SIL OFL License 1.1.txt "SIL OPEN FONT LICENSE Version 1.1")
+The Rainbowstone theme uses the Quicksand font which is licensed under the 
[SIL OPEN FONT LICENSE Version 
1.1](https://raw.githubusercontent.com/apache/ofbiz-framework/trunk/LICENSE)

Review comment:
       Thanks Wang,
   
   I made some changes at 
   
https://github.com/apache/ofbiz-framework/commit/a80c12ae3344c2c899564e5f75dfd975240c9115/
 
   +
   
https://github.com/apache/ofbiz-framework/commit/2cf1e9d490234e7758c0d1b937d50eaa0367173d/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org