[
https://issues.apache.org/jira/browse/OFBIZ-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378410#comment-17378410
]
Xin Wang commented on OFBIZ-12272:
----------------------------------
Hi [~nmalin],
Find some time to have a try with your patch, a big improvement! I really
appreciate it.
Following are two problems I encountered when trying some simple CRUD tests:
1. Error message is not displayed when updating is failed, steps to reproduce:
a) create a WorkEffort with type as "Available" and status as "[General]
Cancelled"
b) update this newly created WorkEffort, change status to "[Task] Completed"
Step (b) should be failed and an error message should be displayed.
2. The height of modal dialog seems not be adjusted according to the contained
contents, e.g.:
a) In creating dialog, there is some blank at the bottom of modal dialog
b) in updating dialog, contents is overflowed and a scrollbar is displayed in
modal dialog
I'm using Edge 91.0.864.67 in a 1920x1080 laptop display.
> Miscellaneous improvements to FindWorkEffort screen
> ---------------------------------------------------
>
> Key: OFBIZ-12272
> URL: https://issues.apache.org/jira/browse/OFBIZ-12272
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Xin Wang
> Assignee: Nicolas Malin
> Priority: Major
> Attachments:
> 0001-Miscellaneous-improvements-to-FindWorkEffort-screen.patch,
> OFBIZ-12272-WithDynamism.patch
>
>
> Attached patch add miscellaneous improvements to FindWorkEffort screen:
> 1. Add "noConditionFind" field with value "Y" to FindWorkEffort screen to
> show results without click "Find" button
> 2. Change response type of deleteWorkEffort from "view" to
> "request-redirect", so that user can stay in FindWorkEffort screen after
> deletion
> 3. Remove "buttontext" widget style of workEffortId column, as text of this
> column also contains workEffortName, and it may be very long and even wrapped
> for two lines, "buttontext" does not fit it quite well
> 4. Change ListWorkEfforts from "form" to "grid", and enable "sort-field" for
> most of the columns (except "description")
> 5. Change "workEffortId" field text from "${workEffortName}
> [${workEffortId}]" to "[${workEffortId}] ${workEffortName}", to be consistent
> with the sort order, as this column is sort by workEffortId
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
