[
https://issues.apache.org/jira/browse/OFBIZ-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384907#comment-17384907
]
Daniel Watford commented on OFBIZ-12274:
----------------------------------------
Hi [~dram],
A PR has been created at https://github.com/apache/ofbiz-framework/pull/314,
please could you take a look.
I think I can refactor further, but was out of time. One thing I'd like to
change is rename classes from RenderableFtl to something like FtlElement since
they are no longer renderable by themselves, but instead are a container of
information related to an FTL element.
> Add FtlWriter.processWithArgs
> -----------------------------
>
> Key: OFBIZ-12274
> URL: https://issues.apache.org/jira/browse/OFBIZ-12274
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Xin Wang
> Assignee: Daniel Watford
> Priority: Major
> Attachments:
> 0001-Rendering-RenderableFtlMacroCall-with-with_args.patch
>
>
> When calling FTL macro from Java side is needed, instead of crafting a
> template string with carefully escaping. with newly added
> FtlWriter.processWithArgs, we can pass parameters using an environment
> variable, and then invoke macro with "with_args" builtin. With this approach,
> it both makes cleaner code and free of fragile escaping.
> As an example, I also changes MacroFormRenderer.makeHyperlinkString to make
> use of this new facility.
> I have created a GitHub PR for this:
> https://github.com/apache/ofbiz-framework/pull/307
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
