[
https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417101#comment-17417101
]
Jacques Le Roux commented on OFBIZ-12016:
-----------------------------------------
Hi Sebastian,
About
bq. I noticed, that in SafeObjectInputStream.java we throw a ClassCastException
which isn't catched anywhere.
I guess you speak about SafeObjectInputStream::getObjectException. Then that's
not exactly true. It's indeed not cathed in UtilObject::getObjectException, and
that's on purpose. ClassCastException, ClassNotFoundException, IOException are
rather thrown and catched by callers (ie EntityCrypto::doDecrypt and
SafeObjectInputStream::getObject, I don't consider tests here). As Nicolas
mentionned there is an history there. The last instance you may refer is
OFBIZ-12216. Anyway better use revisions informaiton to followinvestigate the
past if necessary.
I'm not sure what to say about your other remark. Please suggest changes that
fit your needs :)
bq. And there was a special code line for DiskFileItems where a ClassNotFound
Exception was thrown, which was removed again. While this made it impossible to
retrieve error messages from previous requests at least we don't have an
Exception shown on the surface.
> DiskFileItem as request attribute creates problems
> --------------------------------------------------
>
> Key: OFBIZ-12016
> URL: https://issues.apache.org/jira/browse/OFBIZ-12016
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: 18.12.01, Trunk
> Reporter: Sebastian Berg
> Assignee: Jacques Le Roux
> Priority: Major
> Fix For: Upcoming Branch
>
>
> Hi,
> while working on a custom project based on the 18.12.01 version, I noticed a
> problem with the request handling during a request-redirect-noparam if a
> DiskFileItem was involved.
> So the situation for me is as follows: during the first request a file is
> uploaded. I choose a wrong format on purpose, which results in an error
> respond for that event. Nevertheless the DiskFileItem is set as request
> attribute together with the error message.
> The request is finished and based on the controller configurations redirected
> to a second request.
> While handling the second request the previous request's attributes get
> restored (RequestHandler.java line 733ff). This goes down into
> SafeObjectInfo.resolveClass() where an Incompatible class exception is
> thrown. I compared my custom project with the current development status and
> worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in
> OFBIZ-10837.
> While this fixes the issue with the incompatible class exception it also
> makes it impossible to retrieve any attributes from the first request.
> Therefore my error message cannot be shown.
> Is there a way to fix it or is it otherwise necessary to always set
> "fileItems" as request attribute as added in -OFBIZ-11246-?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
