mbrohl commented on pull request #333: URL: https://github.com/apache/ofbiz-framework/pull/333#issuecomment-963254457
Is this PR considered final @PierreSmits ? If yes, please provide a new PR with all changes committed with proper commit messages (they differ between commits and do not stick to the commit message template). Generally, commits should not contain different changes like a bug fix and an improvement (like you can read in https://github.com/apache/ofbiz-framework/pull/333/commits/302b1308ecfc367f5ae607221bd85575b103d298). Also: why do we now have a new service which mixes create and update? Why not have a create and an update service? The code in updateAgreementRole() does not provide the logic which is described in the comment (selecting entities without thruDate). Why all those name changes for requests, forms etc.? Why does some of the demo data has changed timestamps? Why the change of ManufacturingUiLabels within a commit with completely different scope? Why is it necessary to add the timestamp fields for AgreementRole and PartyRole? They are generated automatically like in all other entities which do not have the "no-auto-stamp" set. I'll have a second review pass when a clean PR is provided. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
