[
https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442209#comment-17442209
]
ASF subversion and git services commented on OFBIZ-11960:
---------------------------------------------------------
Commit 97fe0058a89188eb9dadce92b270df220a53e515 in ofbiz-plugins's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=97fe005 ]
Fixed: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
additional-methods.min.js was missing, forgot previously
Unrelated to plugins, but I also tried to use jquery-ui-dist from node
https://www.npmjs.com/package/jquery-ui-dist despite I knew it was less secure
https://www.cvedetails.com/vulnerability-list/vendor_id-6538/product_id-31126/Jquery-Jquery-Ui.html
But it missed at least the lookup icon in Helveticus.
I'll check later when https://www.npmjs.com/package/jquery-ui-dist will provide
a more secure version.
Also in ecommerceI found this error in js console: : "$.timepicker is undefined"
I did not find the reason. Anyway it seems not used in ecommerce.
> Use NPM with gradle to get external JS dependencies
> ---------------------------------------------------
>
> Key: OFBIZ-11960
> URL: https://issues.apache.org/jira/browse/OFBIZ-11960
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL APPLICATIONS
> Affects Versions: Trunk
> Reporter: Aditya Sharma
> Assignee: Aditya Sharma
> Priority: Trivial
> Fix For: Upcoming Branch
>
>
> As discussed
> [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E],
> use gradle-js-plugin to ease out managing the JavaScript dependencies. The
> Gradle plugin allows us to automatically download the js libraries to the
> user's system like the Gradle dependencies, so we no longer need to include
> them with the package. It opens door to all the packages and modules
> available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed
> with Grunt or Gulp implementing tasks to minify external JS and CSS files
> with the custom ones, see
> [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages].
> 1. Add
> [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]:
> Gradle plugin for integrating NodeJS in your build
> 2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in
> webapp
> 3. Use available tasks to install dependencies
>
> [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks]
>
>
> [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin]
> 4. Use the downloaded JS files in node_modules, updating the current path of
> the JS files.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
