JacquesLeRoux commented on pull request #344: URL: https://github.com/apache/ofbiz-framework/pull/344#issuecomment-979186073
Hi Pierre, First I must say that in general it's not a good idea to edit comment sin GitHub. Because there is no history or way to compare once done, or I don't know how. Also I think that mixing comments in Jira and GH PR is not helping. Anyway, here is an answer to your last comment above. You ask about rules, etc. You don't need rules here, just common sense. And it was clearly explained by Michael above. Not all can be ruled, and even with rules you need a judge. Michael and I were your judges here. Though I wonder how for a "Proud contributor of Apache OFBiz since 2008 (without privileges)" you don't see what the problems are. You are lucky I'm in a good day. Here are more details. If you feel cosmetic changes, like renaming things, should be done you should have made them in another PR. I mean changed/renamed AccountingUiLabels.xml, InvoicePayments.groovy, acc-invoices.adoc, HELP_invoicePayments.adoc, the controller.xml, AccountingMenus.xml , in another PR. Only InvoiceForms.xml and InvoiceScreens.xml should have be part of this PR but without renaming in them. You remember https://github.com/apache/ofbiz-framework/commit/6727f46 ? That's what I want to avoid. Even if I must say it certainly has not the same extend here. Also, I don't know if it's related to GitHub patches or how Eclipse apply patches. When using apply patch from clipboard in Eclipse to locally test, file renaming is not working. Maybe it's due to how you rename files and should read https://www.patrick-wied.at/blog/rename-files-and-folders-with-git or something alike? That's what I get in cmd line after saving https://patch-diff.githubusercontent.com/raw/apache/ofbiz-framework/pull/344.patch locally. ``` C:\projectsASF\Git\ofbiz-framework>git apply --stat 344.patch .../accounting/config/AccountingUiLabels.xml | 6 +- .../groovyScripts/invoice/InvoicePayments.groovy | 0 .../asciidoc/_include/HELP_invoicePayments.adoc | 0 .../src/docs/asciidoc/_include/acc-invoices.adoc | 2 - .../webapp/accounting/WEB-INF/controller.xml | 18 +++--- applications/accounting/widget/AccountingMenus.xml | 4 + applications/accounting/widget/InvoiceForms.xml | 42 +++++++++------ applications/accounting/widget/InvoiceScreens.xml | 57 +++++++------------- 8 files changed, 61 insertions(+), 68 deletions(-) C:\projectsASF\Git\ofbiz-framework>git apply --check 344.patch error: patch failed: applications/accounting/config/AccountingUiLabels.xml:24357 error: applications/accounting/config/AccountingUiLabels.xml: patch does not apply error: applications/accounting/groovyScripts/invoice/CreateApplicationList.groovy: No such file or directory error: applications/accounting/src/docs/asciidoc/_include/HELP_editInvoiceApplications.adoc: No such file or directory error: patch failed: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc:56 error: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc: patch does not apply error: patch failed: applications/accounting/webapp/accounting/WEB-INF/controller.xml:213 error: applications/accounting/webapp/accounting/WEB-INF/controller.xml: patch does not apply error: patch failed: applications/accounting/widget/AccountingMenus.xml:171 error: applications/accounting/widget/AccountingMenus.xml: patch does not apply error: patch failed: applications/accounting/widget/InvoiceForms.xml:188 error: applications/accounting/widget/InvoiceForms.xml: patch does not apply error: patch failed: applications/accounting/widget/InvoiceScreens.xml:182 error: applications/accounting/widget/InvoiceScreens.xml: patch does not apply C:\projectsASF\Git\ofbiz-framework>git am 344.patch error: patch failed: applications/accounting/config/AccountingUiLabels.xml:24357 error: applications/accounting/config/AccountingUiLabels.xml: patch does not apply error: applications/accounting/groovyScripts/invoice/CreateApplicationList.groovy: does not exist in index error: applications/accounting/src/docs/asciidoc/_include/HELP_editInvoiceApplications.adoc: does not exist in index error: patch failed: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc:56 error: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc: patch does not apply error: patch failed: applications/accounting/webapp/accounting/WEB-INF/controller.xml:213 error: applications/accounting/webapp/accounting/WEB-INF/controller.xml: patch does not apply error: patch failed: applications/accounting/widget/AccountingMenus.xml:171 error: applications/accounting/widget/AccountingMenus.xml: patch does not apply error: patch failed: applications/accounting/widget/InvoiceForms.xml:188 error: applications/accounting/widget/InvoiceForms.xml: patch does not apply error: patch failed: applications/accounting/widget/InvoiceScreens.xml:182 error: applications/accounting/widget/InvoiceScreens.xml: patch does not apply hint: Use 'git am --show-current-patch=diff' to see the failed patch Applying: Improved: Invoice Payments for user with 'VIEW' permission (OFBIZ-12384) Patch failed at 0001 Improved: Invoice Payments for user with 'VIEW' permission (OFBIZ-12384) When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ``` So I can't test your changes locally and something must be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
