[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451784#comment-17451784
]
Pierre Smits edited comment on OFBIZ-12424 at 12/1/21, 12:45 PM:
-----------------------------------------------------------------
Nice.
But it seems that this implementation perspective (a developers perspective) is
not something the user would easily get from the title of the menu-item. Nor
from the description provided in the screen.
Would it not be better to rename it 'Move', and adjust the description in the
screen?
Apart from the fact that it can be a benefit for merging duplicate parties, it
also introduces a risk due to mistakes. A wrong ToParty can be selected. Do we
warn the user that his/her/their choice can have major consequences?
Reallocating orders, invoices, payments (and what else that can be regarded as
legal or fiscal records) from one party to another (especially those that were
correct), can bring the company into big financial harm....
Can the user revert this (set of) action(s)?
was (Author: pfm.smits):
Nice.
But it seems that this implementation perspective (a developers perspective) is
not something the user would easily get from the title of the menu-item. Nor
from the description provided in the screen.
Would it not be better to rename it 'Move', and adjust the description in the
screen?
Apart from the fact that it can be a benefit for merging duplicates, it also
introduces a risk due to mistakes. A wrong ToParty can be selected. Do we warn
the user that his/her/their choice can have major consequences?
Reallocating orders, invoices, payments (and what else that can be regarded as
legal or fiscal records) from one party to another (especially those that were
correct), can bring the company into big financial harm....
Can the user revert this (set of) action(s)?
> Link Party feature stop the EECA rules globally
> -----------------------------------------------
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
> Reporter: Rohit Koushal
> Assignee: Rohit Koushal
> Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map<String, Object> linkParty(DispatchContext dctx, Map<String,
> ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
