[
https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453543#comment-17453543
]
ASF subversion and git services commented on OFBIZ-12386:
---------------------------------------------------------
Commit cf086a2b476cc86ed8acc017f42481d8170a50f5 in ofbiz-plugins's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=cf086a2 ]
Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In GitHubEvents::gitHubRedirect, random object created and used only once.
This code creates a java.util.Random object, uses it to generate one random
number, and then discards the Random object. This produces mediocre quality
random numbers and is inefficient. If possible, rewrite the code so that the
Random object is created once and saved, and each time a new random number is
required invoke a method on the existing Random object to obtain it.
Also fixes 2 Javadoc errors
In SampleHtmlThread, uses SecureRandom rather than Random class
In LinkedInEvents::linkedInRedirect, uses SecureRandom rather than Random class
Also fixes 2 Javadoc errors
> Fix some bugs Spotbugs reports
> ------------------------------
>
> Key: OFBIZ-12386
> URL: https://issues.apache.org/jira/browse/OFBIZ-12386
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
