[
https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455334#comment-17455334
]
Pierre Smits commented on OFBIZ-12162:
--------------------------------------
Hi [~jamesyong], [~jleroux]
Why a new form widget type for this?
Isn't the form widget type in combination with the theme driving the experience
of the user?
It seems to me that currently we don't have a theme that caters to this.
Correct? (didn't investigate).
If it were so, wouldn't a SystemProperty record (see below as an example) for a
theme help to determine what to process in FormRender.java, without the need
for a new form widget type (as proposed in the change for widget-form.xsd)?
{code:java}
<SystemProperty systemResourceId="newTheme"
systemPropertyId="form.css-grid-layout"
systemPropertyValue="true"
description="Whether or not to have a css grid layout for forms of
type='single'. Available options: 'true', 'false'"
/> {code}
IMO, the changes regarding the forms should not be in this. If this path (as
proposed by the patch) is followed and included in the codebase as such, there
will be a lot more forms that need to switch over. Correct?
> Single Form Widget on CSS Grid Layout
> -------------------------------------
>
> Key: OFBIZ-12162
> URL: https://issues.apache.org/jira/browse/OFBIZ-12162
> Project: OFBiz
> Issue Type: New Feature
> Components: base
> Affects Versions: Upcoming Branch
> Reporter: James Yong
> Assignee: James Yong
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12162.patch
>
>
> Add a new form widget type i.e. "single_css-grid-layout"
> Whereas single form widget is layout using table, single_css-grid-layout form
> widget is layout using CSS Grid.
> Also will switch FindRequests & FindReturns forms to single_css-grid-layout.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
