[ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458381#comment-17458381
 ] 

Michael Brohl commented on OFBIZ-6670:
--------------------------------------

This is not correct.

SystemProperty is designed to allow overriding the file based configuration 
properties at runtime. SystemProperty will also only work if the underlying 
code uses the EntityUtilProperties API instead of the UtilProperties API. AFAIK 
this is not the case for all properties, thousands use UtilProperties.

It is also not reasonable to have runtime changes for certain properties, e.g. 
when the code fills constants with those properties. A  change in the database 
would have no use later on.

So it makes no sense to demand each configuration property to be in 
SystemProperty.

The projects I know do not use SystemProperty at all or only in rare cases when 
a property has to be changed without restarting the instance. There are several 
other configuration mechanisms used in the field (see Nereide's environment 
variable based approach or ecomify's Gradle based approach). SystemProperty is 
a nightmare for devops because it is not transparent, needs additional sets of 
loading data for each target system and cannot be version controlled in the 
place where it's stored (the database).

So, in my opinion, it is not reasonable to
 * put ALL available properties in SystemProperty
 * make this data load automatically

I propose to have checked which properties make sense to be in the database, 
remove all others and remove it from any automatic loading mechanism. This way 
it is harmless and also provides a good dataset for users using the mechanism 
to chose from.

> Have configuration options for Content.
> ---------------------------------------
>
>                 Key: OFBIZ-6670
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6670
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>             Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to