[
https://issues.apache.org/jira/browse/OFBIZ-11456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458472#comment-17458472
]
ASF subversion and git services commented on OFBIZ-11456:
---------------------------------------------------------
Commit e1633309343ce7be0f1f1e6c58c8e51c720ae1b5 in ofbiz-framework's branch
refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e163330 ]
Improved: Address SpotBugs issue by avoiding nulls in parameter matches for
JMockit Expectations (OFBIZ-11456)
> MacroFormRenderer refactoring
> -----------------------------
>
> Key: OFBIZ-11456
> URL: https://issues.apache.org/jira/browse/OFBIZ-11456
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
> Affects Versions: Trunk
> Reporter: Daniel Watford
> Assignee: Daniel Watford
> Priority: Minor
>
> Class MacroFormRender is 3400 lines long and performs the following:
> * Renders the various form structure parts and field widgets to FTL macros
> calls.
> * Configures the FTL environment.
> * Executes the FTL macro calls to generate HTML and write it to a caller
> provided Appendable.
> Implementing the above means that MacroFormRenderer does not meet the Single
> Responsibility Principle. The current implementation of multiple
> responsibilities makes unit testing difficult.
> As discussed on the dev mailing listÂ
> https://markmail.org/message/adtkk6cb6o7mmy7f it is proposed that
> MacroFormRenderer is refactored.
> Refactoring should separate the rendering of form structure parts and field
> widgets to FTL macro calls from the execution of those macros.
> To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to
> allow test creation against the current implementation of MacroFormRenderer,
> helping to ensure functionality is preserved once refactoring is complete.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
