[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460556#comment-17460556
]
Pierre Smits commented on OFBIZ-10470:
--------------------------------------
IMO, ftl templates should only be used for screen elements where a definition
in a Forms.xml file (form or grid) is either
* impossible to achieve, or
* too complex to be understood easily by a contributor (or a downstream)
developer, or
* javascript code cannot be included in a javascript file that is referenced
in a screen definition where it is needed
Definitions of the type screenlet (or rather anything that can be a screen
level), however, are not part of a form or grid definition, and should
therefore not be part of the ftl template.
> Inconsistent screenlet-title containers
> ---------------------------------------
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Dennis Balkir
> Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <!-- insert screenlet-title -->
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <div class="h3">Title</div>
> {code}
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <h3>Title</h3>
> {code}
> # {code:html}
> <div class="screenlet">
> <div class="screenlet-title-bar">
> <ul>
> <li class="h3">Title</li>
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather
> confusing than useful
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
