bjugl commented on a change in pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773682160



##########
File path: applications/content/widget/CommonScreens.xml
##########
@@ -33,6 +33,7 @@ under the License.
                 <set field="layoutSettings.companyName" 
from-field="uiLabelMap.ContentCompanyName" global="true"/>
                 <set field="layoutSettings.companySubtitle" 
from-field="uiLabelMap.ContentCompanySubtitle" global="true"/>
                 <set field="layoutSettings.styleSheets[]" 
value="/contentimages/css/contentForum.css" global="true"/>
+                <set field="layoutSettings.styleSheets[]" 
value="/contentimages/css/contentForum.css" global="true"/>

Review comment:
       That seems to be a remnant of an early trial and error phase, that I did 
not clean up properly, sry.
   I decided, to not put them here, but rather into 
"themes/common-theme/widget/CommonScreens.xml" in "GlobalActions". This way, 
everything is neatly in common-theme, apart from the WebSiteCMSNav.ftl. I would 
just clean up this extra line, or do you suggest another way of implementation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to