[
https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476788#comment-17476788
]
ASF subversion and git services commented on OFBIZ-11345:
---------------------------------------------------------
Commit 092f8f532a628d56174c5eb8850774c61375c0c2 in ofbiz-framework's branch
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=092f8f5 ]
Improved: List and Grid (OFBIZ-11345) (#423)
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
SubscriptionScreens.xml: from form ref to grid ref , additional cleanup
SubscriptionForms.xml: from form definition with list ref to grid definition
with list ref, additional clean-up
jleroux: some modification after pushing previous commit from GH
In previous commit I noticed that Pierre used the CommonProduct label that I
committed for Pierre's "Adding som Dutch translations to common labels."
OFBIZ-6016
I did not notice then that there was already a more complete ProductProduct
label. I see no reason to create a new CommonProduct label. So I copied 2 lines
not present in ProductProduct from CommonProduct and removed the "nl" line that
is a duplicate of the "en" line.
With Michael we already said to Pierre that we don't like to review, before
pushing PR, not related changes mixed with what is announced by the title. It
complicates the review. I still remember being admonished by David E. Jones when
committing as a new committer doing the same. In the same David's spirit I see
no necessity to remove empty lines when it complicates the review...
Long story short, better make 2 different PR when such things is really
necessary...
I did not remove the <sub-hyperlink from communicationEventId lookup in
SubscriptionForms.xml. I checked there are 21 other cases like that in code.
Also better to remember to have lines not longer than 80 chars in commit
comment.
All the rest is OK with me
> Lists and grids
> ---------------
>
> Key: OFBIZ-11345
> URL: https://issues.apache.org/jira/browse/OFBIZ-11345
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
> Labels: cleanup, refactoring, widget
>
> According to the definition in widget-form.xsd the use of a combination of a
> form with type="list" is deprecated in favour of a grid.
> Refactor various list forms into grids.
> Refactor various list form references in screens.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
