[
https://issues.apache.org/jira/browse/OFBIZ-12489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481153#comment-17481153
]
Michael Brohl commented on OFBIZ-12489:
---------------------------------------
Thanks Jacques.
I think you misunderstood my point respectively I made myself not clear enough.
I know that we agreed upon the use of common labels vs. specific labels and
simply put a reminder to give context. I didn't meant to say that you don't
care about labels and I'm sorry if it came across this way.
I totally agree with your statement "I have always thought that example is
better than commanding."
In this case, I do not think the lack of example is the problem. We've spent a
lot of energy together to explain the points with common vs. specific labels
and quite a few issues were resolved as "Won't do" in this course.
Being unfair was in no way targeted to you but to the contributor who seems to
intentionally ignore past decisions and still tries to sneak in his point of
view through contributions, often not even mentioning those changes in the
commit messages.
As a result, I won't commit those changes but insist that the contributor does
the correction before the changes go to the codebase. Why should anyone else be
bothered with this task than the contributor himself?
Not sure if it will be a lesson because it had no consequences for the
contributor. Where's the learning effect then?
I will spent my time reviewing and commenting the PR's which I did the last
days. I'm not sure if I am able or willing to spent my time correcting things
which easily could have been avoided in the first place, we will see.
> Product Prices - VIEW permissions
> ---------------------------------
>
> Key: OFBIZ-12489
> URL: https://issues.apache.org/jira/browse/OFBIZ-12489
> Project: OFBiz
> Issue Type: Improvement
> Components: product/catalog
> Affects Versions: Upcoming Branch
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
> Labels: permissions, price, product, trust, usability, ux
> Fix For: Upcoming Branch
>
>
> Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo
> with userId = auditor, accessing the product prices screen, sees editable
> fields and/or triggers (to requests) reserved for users with 'CREATE' or
> 'UPDATE' permissions.
> See (test with):
> https://localhost:8443/catalog/control/EditProductPrices?productId=WG-9943
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
