[ 
https://issues.apache.org/jira/browse/OFBIZ-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Florian Motteau updated OFBIZ-12660:
------------------------------------
    Description: 
h3. If
 * current locale is tr-TR (and most certainly az-AZ, maybe others, where 
[dotless i|https://en.wikipedia.org/wiki/Dotless_I] exists),
 * the theme name contains a "i" (`RAINBOWSTONE-SAPHIR` for example),
 * the theme uses this line in /template/includes/Header.ftl to generate a link 
to a Less file (rainbowstone, helveticus, maybe others) :

{code:java}
<link rel="stylesheet/less" 
href="<@ofbizContentUrl>/helveticus/${visualTheme.visualThemeId?replace("_","-")?lower_case}.less</@ofbizContentUrl>"
 type="text/css"/>{code}
h3. Then
 * the Freemarker `lower_case` function generates dotless i's when lowercasing 
"I",
 * the link to the Less ends up with a 404
 * no more styles :/

See [^turkish-dotless-i-bug.mp4]
h3. Leads to fix this
 * Find a way to override the current locale for `lower_case` calls (and always 
use en-EN)
 * Do not rely on a locale sensitive function to generate links to style files
 * Ban "i" in visual theme names :)
 * more ideas ?

  was:
h3. If
 * current locale is tr-TR (and most certainly az-AZ, maybe others, where 
[dotless i|https://en.wikipedia.org/wiki/Dotless_I] exists),
 * the theme name contains a "i" (`RAINBOWSTONE-SAPHIR` for example),
 * the theme uses this line in /template/includes/Header.ftl to generate a link 
to a Less file (rainbowstone, helveticus, maybe others) :

{code:java}
<link rel="stylesheet/less" 
href="<@ofbizContentUrl>/helveticus/${visualTheme.visualThemeId?replace("_","-")?lower_case}.less</@ofbizContentUrl>"
 type="text/css"/>{code}
h3. Then
 * the Freemarker `lower_case` function generates dotless i's when converting 
"I",
 * the link to the Less ends up with a 404
 * no more styles :/

See [^turkish-dotless-i-bug.mp4]
h3. Leads to fix this
 * Find a way to override the current locale for `lower_case` calls (and always 
use en-EN)
 * Do not rely on a locale sensitive function to generate links to style files
 * Ban "i" in visual theme names :)
 * more ideas ?


> Wrong Less file URL when locale is tr-TR
> ----------------------------------------
>
>                 Key: OFBIZ-12660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12660
>             Project: OFBiz
>          Issue Type: Bug
>          Components: themes
>    Affects Versions: 18.12.06, 22.01.01, Upcoming Branch
>            Reporter: Florian Motteau
>            Priority: Major
>         Attachments: turkish-dotless-i-bug.mp4
>
>
> h3. If
>  * current locale is tr-TR (and most certainly az-AZ, maybe others, where 
> [dotless i|https://en.wikipedia.org/wiki/Dotless_I] exists),
>  * the theme name contains a "i" (`RAINBOWSTONE-SAPHIR` for example),
>  * the theme uses this line in /template/includes/Header.ftl to generate a 
> link to a Less file (rainbowstone, helveticus, maybe others) :
> {code:java}
> <link rel="stylesheet/less" 
> href="<@ofbizContentUrl>/helveticus/${visualTheme.visualThemeId?replace("_","-")?lower_case}.less</@ofbizContentUrl>"
>  type="text/css"/>{code}
> h3. Then
>  * the Freemarker `lower_case` function generates dotless i's when 
> lowercasing "I",
>  * the link to the Less ends up with a 404
>  * no more styles :/
> See [^turkish-dotless-i-bug.mp4]
> h3. Leads to fix this
>  * Find a way to override the current locale for `lower_case` calls (and 
> always use en-EN)
>  * Do not rely on a locale sensitive function to generate links to style files
>  * Ban "i" in visual theme names :)
>  * more ideas ?



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to