[
https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606084#comment-17606084
]
Jacques Le Roux commented on OFBIZ-12390:
-----------------------------------------
Hi Ingo,
There is a pb w/ your patch:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git apply --reject cartRounding.patch
Checking patch
applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java...
Checking patch
applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java...
error: while searching for:
curDisplayPrice = this.getBasePrice();
} else {
if (selectedAmount.compareTo(BigDecimal.ZERO) > 0) {
curDisplayPrice =
this.displayPrice.multiply(this.selectedAmount).setScale(3,
UtilNumber.getRoundingMode("order.rounding"));
} else {
curDisplayPrice = this.displayPrice.setScale(3,
UtilNumber.getRoundingMode("order.rounding"));
}
}
return curDisplayPrice;
error: patch failed:
applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java:2355
Hunk #2 succeeded at 2554 (offset -3 lines).
Applied patch
applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
cleanly.
Applying patch
applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
{noformat}
>From what I have seen with another tool (ToirtoiseGit) the pb is related to
><<index b0648c9..13750d0 100644>>
Please create your patch using trunk HEAD, TIA
> Order/Invoice: Item total result diff total result
> --------------------------------------------------
>
> Key: OFBIZ-12390
> URL: https://issues.apache.org/jira/browse/OFBIZ-12390
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting, order
> Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch
> Reporter: Ingo Wolfmayr
> Assignee: Jacques Le Roux
> Priority: Major
> Attachments: Orders.xml, cartRounding.patch,
> image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png,
> image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png,
> pricecheckData-1.xml
>
>
> In some cases the order total is not correct:
> net price: €1.273
> 10% sales tax: € 0.127
> quantity: 1
> grand total: € 1.40
> Now taking the same product and adding it with two order lines:
> grand total: € 2.79
> Right now the grand total is calculated by total all item net prices, total
> all adjustments and finally adding those two values together.
> The following screenshots are taken from the orderview. Ofbiz request a
> payment of € 2.80 but will create an invoice with a grand total of € 2.79.
> !image-2021-11-19-09-44-18-759.png!
> !image-2021-11-19-09-44-44-443.png!
> Heres the result with just one orderline:
> !image-2021-11-19-09-59-07-571.png!
>
> I have created a XML file for testing. Import the file via XML import and
> create an order:
> partyId: AUT_CUSTOMER
> productStore: Test GmbH
> product 1: AUT_PRODUCT (quantity 1)
> product 1: AUT_PRODUCT_CP (quantity 1)
> Checkout with default settings.
> From my perspective the calculation should be changed to calculate the total
> amount for each line and calculate the grand total from these results.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
