[ 
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609955#comment-17609955
 ] 

Jacques Le Roux edited comment on OFBIZ-10480 at 9/27/22 10:22 AM:
-------------------------------------------------------------------

Commit 19676d430616a9d3be5228283f4381a37c3c8138 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=19676d4306 ]

Improved: Reducing scope of variables in org.apache.ofbiz.common package 
(OFBIZ-10480)

jleroux: maybe because not all was applied or code changed, (or?) I had to

revert

    public ScriptHelperImpl(ScriptContext context) {
    + ScriptHelperImpl(ScriptContext context) {

Thanks: Pradhan Yash Sharma for the patch



was (Author: jacques.le.roux):
Commit 19676d430616a9d3be5228283f4381a37c3c8138 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=19676d4306 ]

Improved: Reducing scope of variables in org.apache.ofbiz.commonpackage 
(OFBIZ-10480)

jleroux: maybe because not all was applied or code changed, (or?) I had to

revert

    public ScriptHelperImpl(ScriptContext context) {
    + ScriptHelperImpl(ScriptContext context) {

Thanks: Pradhan Yash Sharma for the patch


> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10480
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10480
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: 22.01.01, Upcoming Branch
>            Reporter: Pradhan Yash Sharma
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be 
> done on this package. Not to limit this ticket for only variable/method 
> scoping.
> Please let me know if anyone has any issue and I will revert the update.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to