[ 
https://issues.apache.org/jira/browse/OFBIZ-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618250#comment-17618250
 ] 

Giulio Speri commented on OFBIZ-9361:
-------------------------------------

HI, [~adityasharma],

thanks!

 

I've just finished to review and adapt the patch to the current trunk revision 
and it's work fine for the _Accepted_ requests part.

However I have a doubt about the Contact List _Pending_ requests: now if you 
try to sign up again but you already have a pending request, another contact 
list record with newer fromDate is added (and verification email is then sent 
to the user).

If I sign up many times, the service will add more and more records to the 
ContactListParty entity: shouldn't we delete or at least expire the older 
active (pending) records before adding new ones ?

 

 

> Newsletter can be subscribed with same email address multiple times
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-9361
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9361
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 16.11, Trunk, Upcoming Branch
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>            Priority: Trivial
>         Attachments: OFBIZ-9361.patch
>
>
> Steps to regenerate:
> 1. Go to Ecommerce component 
> (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main)
> 2. In Sign Up For Contact List section from the left panel, select 
> contactList for Newsletter.
> 3. Fill out the email address and Click on Subscribe button.
> Try subscribing with the same email address for the newsletter. Email is 
> again added to Newsletter subscription list even if it is already subscribed 
> for it. Email address with pending and accepted status can be again added to 
> the list with pending status.
> Multiple entries are created in ContactListParty entity for the same 
> preferredContactMechId.
> At Service level, it should check if already an entry in pending or accepted 
> status exists.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to