[
https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620286#comment-17620286
]
Jacques Le Roux commented on OFBIZ-12659:
-----------------------------------------
I pushed the PR and will backport from there.
I thought that the commit message would content what is in the GH issue
description, ie
{quote}
Improved: Make lookup's no result message not selectable
(OFBIZ-12659)
Explanation
On lookups, the "No result" dropdown option should no be selectable. With this
PR, clicking on "No result" empties the input (removes the search text).
See
https://issues.apache.org/jira/secure/attachment/13045667/lookups-no-record-found.mp4
Thanks: Nereide Team (actually Nereide as no accent, if I'm right ;) )
{quote}
But actually only the title was there:
bq. Improved: Make lookup's no result message not selectable #553
So here I copy some more information from the commit (not the code part)
{quote}
the following commit(s) were added to refs/heads/trunk by this push:
new a7f5a03845 Improved: Make lookup's no result message not selectable
(#553)
a7f5a03845 is described below
commit
[a7f5a03845500a513897f7a8d815a48a447749f2|https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=a7f5a03845500a513897f7a8d815a48a447749f2]
Author: Florian Motteau <[email protected]>
AuthorDate: Wed Oct 19 13:41:01 2022 +0200
Improved: Make lookup's no result message not selectable (#553)
{quote}
This is stil obscure to me. Sometimes the description is incluced when you push
a PR, sometimes not?
Anyway better to always include the Jira ref in the title to be sure that it
will be intercepted and included as a Jira comment.
> Lookups: No result option should not be selectable
> --------------------------------------------------
>
> Key: OFBIZ-12659
> URL: https://issues.apache.org/jira/browse/OFBIZ-12659
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: 18.12.05, 22.01.01, Upcoming Branch
> Reporter: Florian Motteau
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-12659.patch, lookups-no-record-found.mp4
>
>
> On lookups, if the search request returns nothing, we have a dropdown with
> only one option : "No records found".
> This option is selectable, and when the user clicks it the input is filled
> with the string "No records found". When the form is submitted, this value is
> submitted as well.
> The "No records found" option should not be selectable, it should not be
> possible to submit the field with this value. When clicking on this option,
> we could either :
> * leave the input with its previous value (do nothing)
> * empty the input
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
